Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DCL and Pro*FORTRAN .pfo files #822

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

pweaver2019
Copy link
Contributor

Added filetype PFO under FORTRAN for Oracle Pro-Form files, added new entries for "Digital Command Language" and "Command Language Definition" for OpenVMS systems. Both shades of orange to match The Great Orange Wall.

Added filetype PFO under FORTRAN for Oracle Pro-Form files,  added new entries for "Digital Command Language" and "Command Language Definition" for OpenVMS systems. Both shades of orange to match The Great Orange Wall.
Copy link
Member

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @pweaver2019, thanks for the PR. 👋

I've closed #821 because change-log updates should ideally be included in the original pull-request (unless it's already been merged, necessitating a separate PR). Could you update the change-log as follows...?

 [Unpublished]
 ----------------------
 ### Added
-- **Support:** Config: JS (`.eshost-config.json`, `.eshost.json`), Husky (`.huskyrc.yml`, `.huskyrc.yaml`), Vercel (`.vercelignore`, `vercel.json`)
+- **Support:** Config: JS (`.eshost-config.json`, `.eshost.json`), Fortran (`.pfo`), Husky (`.huskyrc.yml`, `.huskyrc.yaml`), Vercel (`.vercelignore`, `vercel.json`)
 

The DCL extensions will also need to be added (but please see my review comments first).

config.cson Outdated Show resolved Hide resolved
config.cson Outdated Show resolved Hide resolved
@Alhadis Alhadis mentioned this pull request Jul 22, 2020
@Alhadis
Copy link
Member

Alhadis commented Jul 22, 2020

@pweaver2019 Just curious (and this is entirely unrelated to this PR), would you happen to have access to an OpenVMS machine? (Or know how to acquire it?) I recently noticed HP have discontinued the hobbyist VMS program, defeating my hope of ever exploring the system (I knew I should have registered earlier…)

@Alhadis Alhadis changed the title Update config.cson Add support for DCL and Pro*FORTRAN .pfo files Jul 22, 2020
@pweaver2019
Copy link
Contributor Author

pweaver2019 commented Jul 22, 2020 via email

@Alhadis
Copy link
Member

Alhadis commented Jul 22, 2020

Have you been able to run VSCode on VMS, though? 🤔 If so, how was it ported?

My interest in VMS stems from my curiosity about how its filesystem and concept of filepaths differs from that of Windows and Unix-like platforms. I'm happy to explore OpenVMS using SimH, but the problem is laying hands on a copy of OpenVMS in the first place. 😢

I manually added the pfo, cld and com entries into the file-icons-icon-theme.json file so that works for me.

Sorry about that. The VSCode and Atom packages differ vastly in their implementation, mainly because the former started life as a QND port of the latter. The file-icons project needs a complete rehaul so there's a SSoT for icon-to-filetype mappings. 😞

@Alhadis Alhadis dismissed their stale review July 22, 2020 20:35

Requested changes pushed to submitter's branch.

@Alhadis
Copy link
Member

Alhadis commented Jul 22, 2020

BTW, don't worry about the changes I requested earlier. I'm trying to wrap up a new release of this package, so I made the necessary changes to your fork myself to move things along a little. 👍

@Alhadis Alhadis merged commit 1e0eb33 into file-icons:master Jul 22, 2020
@pweaver2019
Copy link
Contributor Author

pweaver2019 commented Jul 22, 2020 via email

@Alhadis
Copy link
Member

Alhadis commented Jul 22, 2020

Oh wow, thanks!! Those links look promising, I'll definitely check them out! 😀

I actually remember I downloaded an old version of OpenVMS from, uh, Archive.org of all places. Never tried it since I assumed a license was needed (hence why it wasn't taken down).

If you have never installed VMS then there is a STEEP learning curve

😉 Yup, but that's also another reason I'm eager to try VMS: it's like learning to use a computer all over again. Miss that feeling…

Thanks again for the help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants