Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing a Sector Duration Multiple for Longer Term Sector Commitment #390

Closed
wants to merge 14 commits into from

Conversation

vkalghatgi
Copy link
Contributor

No description provided.

@Fatman13
Copy link
Contributor

Fatman13 commented Jun 23, 2022

Is it normal that this FIP went from a FIP discussion to a PR in just 6 days? @kaitlin-beegle

According to #314,

The lifecycle of a FIP is very long. Ideas that are added to the FIP Discussion Forum are often incrementally worked on over weeks or months.

Also according to #314,

FIP Authors are encouraged to share and solicit feedback on their discussion posts.

It is expected that the FIP Author is a public steward of their FIP, continuously seeking community feedback on their proposal, addressing questions and concerns, and moderating any public discussion which may arise in the discussion forum.

Authors engaged in no conversations with the community in the FIP discussion and went straight to PR.

@jennijuju
Copy link
Member

As an FIP editor speaking - Have a DRAFT fip PR open should be totally fine. authors should continue solicit the idea in the discussion, and update the DRAFT FIP accordingly before the DRAFT can be considered to move forward to LAST CALL.

@kaitlin-beegle
Copy link
Collaborator

Is it normal that this FIP went from a FIP discussion to a PR in just 6 days? @kaitlin-beegle

According to #314,

The lifecycle of a FIP is very long. Ideas that are added to the FIP Discussion Forum are often incrementally worked on over weeks or months.

Also according to #314,

FIP Authors are encouraged to share and solicit feedback on their discussion posts.

It is expected that the FIP Author is a public steward of their FIP, continuously seeking community feedback on their proposal, addressing questions and concerns, and moderating any public discussion which may arise in the discussion forum.

Authors engaged in no conversations with the community in the FIP discussion and went straight to PR.

You raise a fair point- it is preferable for there to be longer lead time between opening a discussion and pushing a FIP draft. I went ahead and let the team know, so in the future we are aware in advance of any items that they're working on!

However, @jennijuju is also correct: just because a PR is open or a FIP draft is merged, does not mean it is going to be accepted. In fact, the team needs to respond to your comments, questions, concerns, etc., in the discussion before we can consider this ready for 'Last Call'.

So, keep asking your questions! It's a good practice.

@steven004
Copy link
Contributor

I think a basic problem here is that one might be confused to put comments here or in the discussion, and the author is willing to respond in which place.

I would think it is better to achieve general consensus in the discussion first, and then have a FIP draft for refining.

@kaitlin-beegle
Copy link
Collaborator

I think a basic problem here is that one might be confused to put comments here or in the discussion, and the author is willing to respond in which place.

I would think it is better to achieve general consensus in the discussion first, and then have a FIP draft for refining.

I agree! That is the process. I've asked the team to be more proactive about following this going forward!

Also, authors are responsible for addressing comments on both discussions and on the draft itself. Although community conversations are best held in the discussion, we don't want to restrict community members from commenting directly on drafts.

@jennijuju
Copy link
Member

given the comments above - id like to propose converting this PR into a draft PR - and reopen for reviewing & FIP number assignment after FIP authors ack & address the valid/common comments from the discussion.

@jennijuju jennijuju marked this pull request as draft July 26, 2022 04:24
@jennijuju
Copy link
Member

@vkalghatgi as suggested above, I converted this PR into a draft for now. Please feel free to reopen the PR once more details are added to the FIP draft and tag one of the editors to review!

@kaitlin-beegle
Copy link
Collaborator

Closing this PR; a new PR will soon be opened with an updated draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants