FIP-0045: update to match deployed types #961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: it was discovered (by @LexLuthr) that
ClaimExtensionRequest
has been implemented wrong in go-state-types so has not been a functional API on the network since nv10, although it was launched (as per this FIP) in nv9 with the types matching. That's being rectified in filecoin-project/go-state-types#254, although it's conforming to the implementation found in builtin-actors rather than the text of the spec in this FIP.In the process of proposing a retroactive fix to this spec to match the deployed implementation, I've discovered that there are a lot more mismatched types between spec and implementation, so I've adjusted them all here. This isn't a new FIP, but rather an alignment of the spec if we view the spec as a combination of the FIP text and the builtin-actors implementation; and the only thing changing in code as a result of this is a fix to make
ClaimExtensionRequest
work.Address
in here were launched in nv9 asActorID
.AllocationRequest
andClaimExtensionRequest
went live in nv9 withprovider
asAddress
but in nv10 switched toActorID
.ClaimExtensionRequest
was never adjusted in go-state-types toActorID
so has been unable to successfully parse or pass on these to builtin-actors.ExtendClaimTerms
appears to have been the only mechanism used to extend claim terms since this FIP.int64
which is the base type used in implementations.AllocationRequest
andClaimExtensionRequest
fields.