Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial boost / fvm contract deals support #1183

Merged
merged 50 commits into from
Feb 23, 2023
Merged

initial boost / fvm contract deals support #1183

merged 50 commits into from
Feb 23, 2023

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Feb 14, 2023 •
edited
Loading

This PR is adding a chain monitor for the DealProposalCreate event as described at:

Given that this is not a final FRC, this functionality might change in the near future.

By default the monitor is disabled, users should enable it by updating a few values in config.toml

Based on DealClient solidity contract at: https://github.com/nonsense/fevm-hardhat-kit/blob/nonsense/deal-client-contract/contracts/basic-deal-client/DealClient.sol

MUST FIX:

  • fix/review client mismatch

NICE TO HAVE:

  • fix CBOR generation task
  • once the FRC is somewhat stable add an itest

nonsense and others added 28 commits February 2, 2023 15:26
@nonsense
fix docker builds to do make hyperspacenet for lotus
82b4238
@nonsense
fixup
477e663
@nonsense
fixup
9e825cd
@nonsense
fix env
07ed679
@nonsense
remove lotus-test for now as it is mostly broken
d20d87e
@nonsense
fixup
0dc421a
@nonsense
fixup
5b830ef
@nonsense
fixup
046152f
@nonsense
use same commit as lotus
d0c42d0
@nonsense
bump filecoin-ffi
303678e
@nonsense
fixup
f8017b0
@nonsense
upgrade lotus
7831768
@nonsense
fix SealerConfig
938c32e
@nonsense
use nil SendSpec
2149396
@nonsense
fix paths.StorageConfig
6a26bb1
@nonsense
add node start time
373fb09
@nonsense
env vars
95a83db
@nonsense
rename ExecuteDeal to ExecuteLibp2pDeal
a76f9ad
@nonsense
rename HandleBoostDeals
274bdc8
@dirkmc
refactor: move deal accept / reject logging to be part of deal execut…
aa2df33 
…ion (#1172)
@nonsense
eth abi package
5b365a3
@nonsense
fix conflicts
bb67bd9
@nonsense
fixup
9707366
@dirkmc
feat: skip signature validation for f4 (fvm contract) addresses (#1178)
b4b21bb
@nonsense
pkg rewrite
b9c89be
@dirkmc
feat: highlight f4 addresses in UI (#1179)
f891679
@dirkmc
feat: verify deal proposal for f4 address (#1181)
276e2d9
@nonsense
lint
4eaa8b9
@jacobheun jacobheun mentioned this pull request Feb 15, 2023
Merged
1 task
@nonsense nonsense removed the status/in-progress Status: In Progress label Feb 22, 2023
@nonsense nonsense marked this pull request as ready for review February 22, 2023 12:31
@nonsense nonsense requested a review from dirkmc February 22, 2023 12:37
dirkmc
dirkmc reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work! 🙌

cmd/boostd/run.go Show resolved Hide resolved
storagemarket/contract_deal_monitor.go Show resolved Hide resolved
storagemarket/contract_deal_monitor.go Outdated Show resolved Hide resolved
storagemarket/types/contract_deal_proposal_types.go Outdated Show resolved Hide resolved
nonsense
nonsense commented Feb 23, 2023
View reviewed changes
storagemarket/contract_deal_monitor.go
Size: pv1.CarSize,
},
//TODO: maybe add to pv1?? RemoveUnsealedCopy: paramsAndVersion.RemoveUnsealedCopy,
RemoveUnsealedCopy: false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirkmc we should add RemoveUnsealedCopy into ParamsVersion1, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think that makes sense 👍

@nonsense nonsense changed the title fvm hyperspace interop initial boost / fvm contract deals support Feb 23, 2023
@nonsense nonsense merged commit e1a3ad9 into main Feb 23, 2023
@nonsense nonsense deleted the nonsense/hyperspace branch February 23, 2023 14:24
@nonsense nonsense mentioned this pull request Feb 23, 2023
Closed
6 tasks
@xBalbinus xBalbinus mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc left review comments

@jacobheun jacobheun Awaiting requested review from jacobheun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonsense @dirkmc