FRC DealProposal integration #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
commented
Feb 25, 2023
nonsense
force-pushed
the
nonsense/frc-dealproposal-integration
branch
3 times, most recently
from
747d9d7
to
c665e56
Compare
nonsense
force-pushed
the
nonsense/frc-dealproposal-integration
branch
from
c665e56
to
97b2677
Compare
dirkmc
approved these changes
Mar 3, 2023
storagemarket/helper.go
Outdated
| p1ClientID == p2ClientID, nil | ||
| p1ClientID == p2ClientID | ||
|
|
||
| log.Warnw("check deal quality", "result", res, "p1clientid", p1ClientID, "p2clientid", p2ClientID, "label_equality", p1.Label.Equals(p2.Label), "provider_equality", p1.Provider == p2.Provider) |
There was a problem hiding this comment.
Maybe log this at the debug level
nonsense
commented
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial DealProposal FRC has been merged into Boost already. This PR is a follow-up to solidify the remaining items as described in #1215 as well as any changes that might come up in the actual FRC.
TODO:
v1.20.0-rc2-boost