Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CONTRIBUTING.md #1603

Merged
merged 9 commits into from
Aug 6, 2023
Merged

Create CONTRIBUTING.md #1603

merged 9 commits into from
Aug 6, 2023

Conversation

brendalee
Copy link
Collaborator

Add external contribution guidelines (first version)

LexLuthr
LexLuthr reviewed Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend moving the file out of .github as we will have a single page guide.
Having it in the main directory structure would make it more visible.

We should also add a link from README to this guide.

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@brendalee
Update CONTRIBUTING.md
0c28640 
update instructions on where to include docs/detailed explanation in the PR
@brendalee
Update CONTRIBUTING.md
3f310ff 
edited requirements on what to include in PRs
@brendalee
Create CONTRIBUTING.md
6c94629 
move contributing page
@brendalee
Delete CONTRIBUTING.md
859c8fc 
moved to root directory
@brendalee
Update README.md
c689880 
add external contribution guidelines to readme
@brendalee
Copy link
Collaborator Author

@LexLuthr please review, I think I covered all your suggestions.

LexLuthr
LexLuthr reviewed Aug 4, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
LexLuthr
LexLuthr reviewed Aug 4, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@LexLuthr
Copy link
Collaborator

LexLuthr commented Aug 4, 2023

I have suggested a couple of more changes. The use of tags will make it easier of us to identify which PR requires docs and I can make the changes.

brendalee and others added 3 commits August 6, 2023 00:00
@brendalee @LexLuthr
Update CONTRIBUTING.md
70ff09d 
adding tags per @LexLuthr suggestions

Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>
@brendalee @LexLuthr
Update CONTRIBUTING.md
2e0df35 
adding tags per @LexLuthr suggestions

Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>
@brendalee @LexLuthr
Update CONTRIBUTING.md
6095706 
adding tags per @LexLuthr suggestions

Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>
@brendalee brendalee merged commit f7e82e8 into main Aug 6, 2023
@brendalee brendalee deleted the brendalee-patch-1 branch August 6, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendalee @LexLuthr