Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct data onboarding - disabled #1627

Merged
merged 67 commits into from
Oct 5, 2023
Merged

direct data onboarding - disabled #1627

merged 67 commits into from
Oct 5, 2023

Conversation

nonsense
Copy link
Member

@nonsense nonsense commented Aug 16, 2023

This PR is adding:

  • import-direct CLI command to trigger direct data onboarding
  • DirectData Boost API
  • FIL+ support for the Boost devnet
  • the initial provider for handling direct data onboard calls from CLI
  • initial db tables and migrations, since direct data doesn't fit the existing Boost Deal model
  • initial direct data model (called DirectDataEntry)

So far this PR lacks:

  • [ ] tests - to be added only once we are happy with behavior and makes sense to lock it - we skip tests for now, as DDO stays disabled until it gets into a network upgrade.
  • UI - Boost UI needs to visualize all direct data entries, and follow their sealing lifecycle, similarly to current Boost deals
    Web UI: direct deals list #1665
  • logs - we want to record the lifecycle of a direct data import, similarly to current Boost deals
  • allocate cmd - add cmdline args to specify "TermMin", "TermMax", "Expiration"
    feat: user defined allocation policy #1668
  • CleanupData - make sure we cleanup original CAR if CleanupData is specified.

@jennijuju jennijuju linked an issue Aug 24, 2023 that may be closed by this pull request
LexLuthr and others added 7 commits August 28, 2023 17:21
* add allocate & get-allocations command

* comment out fullNode dependent lines

* clarify error

* update lotus, uncomment check code

* go mod tidy

* bump FFI, fix EthCall

* docsgen
…etries, retries on startup (#1650)

* extract and refactor commp for direct deals

* split Import into Import and Process, and Process all deals on startup

* update Process with checkpoints check

* handle commp size
* comment

* add signers and notaries

* fixup

* fixup
@nonsense nonsense force-pushed the nonsense/ddo branch 3 times, most recently from 1c4abf9 to 52998cd Compare October 2, 2023 14:39
@nonsense nonsense removed the status/in-progress Status: In Progress label Oct 3, 2023
@nonsense nonsense marked this pull request as ready for review October 3, 2023 11:33
@nonsense
Copy link
Member Author

nonsense commented Oct 3, 2023

Marking this PR as ready for review, with the idea that some DDO code is commented out, until it gets support in Lotus and actors, and until we get clarity on how it affects the deal model.

Within the Boost team we've made the decision to merge into main in order to avoid conflicts in the future, and have an easier time adding full support, when DDO gets into the mainnet network.

Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cmd/boostd/main.go Outdated Show resolved Hide resolved
@ischasny
Copy link
Collaborator

ischasny commented Oct 3, 2023

Thanks Anton. It will take me some time to review this one - will try to wrap my head around it today / tomorrow!

Copy link
Collaborator

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the APIs hidden as well?

node/impl/boost.go Outdated Show resolved Hide resolved
@nonsense nonsense changed the title direct data onboarding direct data onboarding - disabled Oct 5, 2023
@nonsense nonsense merged commit 06d02cc into main Oct 5, 2023
1 check passed
@nonsense nonsense deleted the nonsense/ddo branch October 5, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Direct Data Onboarding Scaffolding
5 participants