-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
direct data onboarding - disabled #1627
Conversation
* add allocate & get-allocations command * comment out fullNode dependent lines * clarify error * update lotus, uncomment check code * go mod tidy * bump FFI, fix EthCall * docsgen
…etries, retries on startup (#1650) * extract and refactor commp for direct deals * split Import into Import and Process, and Process all deals on startup * update Process with checkpoints check * handle commp size
* comment * add signers and notaries * fixup * fixup
599ae20
to
8a8b833
Compare
1c4abf9
to
52998cd
Compare
Marking this PR as ready for review, with the idea that some DDO code is commented out, until it gets support in Lotus and actors, and until we get clarity on how it affects the deal model. Within the Boost team we've made the decision to merge into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks Anton. It will take me some time to review this one - will try to wrap my head around it today / tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the APIs hidden as well?
Co-authored-by: LexLuthr <88259624+LexLuthr@users.noreply.github.com>
…t into nonsense/ddo
This PR is adding:
import-direct
CLI command to trigger direct data onboardingDirectData
Boost APIDirectDataEntry
)So far this PR lacks:
[ ] tests - to be added only once we are happy with behavior and makes sense to lock it- we skip tests for now, as DDO stays disabled until it gets into a network upgrade.Web UI: direct deals list #1665
feat: user defined allocation policy #1668