timeout for migrate-lid #1631
Merged
timeout for migrate-lid #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
nonsense/timeout-for-migrate-lid
branch
from
3d03a1a
to
e8b63f1
Compare
nonsense
force-pushed
the
nonsense/timeout-for-migrate-lid
branch
from
e8b63f1
to
66d5019
Compare
dirkmc
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a timeout of 1 minute when migrating indices from the DAGStore to LID. Migrating should not take more than a few seconds per index. If it takes more than 1 minute, we err the specific index migration, and let the
Piece Doctorfix it after the SP has finished installing and migrating to Boost V2.