Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update docker devnet build #1702

Merged
merged 7 commits into from
Sep 21, 2023
Merged

feat: update docker devnet build #1702

merged 7 commits into from
Sep 21, 2023

Conversation

LexLuthr
Copy link
Collaborator

this PR makes the following changes:

  1. It updates the docker devnet build to use images shipped by https://github.com/filecoin-shipyard/lotus-containers instead of docker.io/filecoin/lotus-all-in-one
  2. Removes the lotus and lotus-miner images built by Boost github action.
  3. Update github action to build images for amd64 and arm64.

@LexLuthr LexLuthr requested a review from masih September 15, 2023 12:41
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since the PR changes the makefile the devnet setup not built from lotus source will break? (though I think it was broken before? not sure).

otherwise lgtm

.github/workflows/container-build.yml Show resolved Hide resolved
@LexLuthr LexLuthr merged commit 9a43315 into main Sep 21, 2023
1 check passed
@LexLuthr LexLuthr deleted the feat/speedup-devnet branch September 21, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants