fix: speed up ydb insert #1793
Merged
fix: speed up ydb insert #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
reviewed
Oct 31, 2023
* speed up ydb indexing by executing inserts in batches instead of concurrently * add insert batch size database setting that is default to 10k
ischasny
force-pushed
the
ivan/speedup-ydb-insert
branch
from
38ac942
to
9a3ebec
Compare
nonsense
approved these changes
Nov 1, 2023
masih
approved these changes
Nov 1, 2023
| for allIdx, rec := range recs { | ||
| if batch == nil { | ||
| batch = s.session.NewBatch(gocql.UnloggedBatch).WithContext(ctx) | ||
| batch.Entries = make([]gocql.BatchEntry, 0, s.settings.InsertBatchSize) |
There was a problem hiding this comment.
Size should be whatever is left, which is at most insertBatchSize, not always.
| }) | ||
| batch.Entries = append(batch.Entries, gocql.BatchEntry{ | ||
| Stmt: insertPieceOffsetsQry, | ||
| Args: []interface{}{trimMultihash(rec.Cid.Hash()), pieceCidBytes}, |
There was a problem hiding this comment.
Suggested change
| Args: []interface{}{trimMultihash(rec.Cid.Hash()), pieceCidBytes}, | |
| Args: []any{trimMultihash(rec.Cid.Hash()), pieceCidBytes}, |
| if batch == nil { | ||
| batch = s.session.NewBatch(gocql.UnloggedBatch).WithContext(ctx) | ||
| batch.Entries = make([]gocql.BatchEntry, 0, s.settings.InsertBatchSize) |
There was a problem hiding this comment.
ditto re slice size.
Would be nice to reduce duplicate code in working with batches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance results
Car file used:
{"piececid": "bafykbzacedrrhwwbp7bcbvekiqzlzvbi65wy2ku6xkejlewz6bciasnnqycd4", "recs": 2232145}2023-11-01T13:06:20.289Z WARN boostd-data cmd/run.go:339 added index to yugabytedb successfully {"took": 244.186086292}2023-11-01T12:51:23.415Z WARN boostd-data cmd/run.go:348 added index to yugabytedb successfully {"took": 47.338054792}2023-11-01T12:53:26.419Z WARN boostd-data cmd/run.go:348 added index to yugabytedb successfully {"took": 40.236502708}2023-11-01T12:52:23.827Z WARN boostd-data cmd/run.go:348 added index to yugabytedb successfully {"took": 35.621975375}