Prefetch state claims to change O(n) calls to Lotus State to O(1) #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my case (140.000 updates) shaves off 1.5 seconds per call (+ the load on the daemon) -> turns a 39 hour job into seconds
10 tasks
|
@RobQuistNL Thank you for the PR. Looks good. |
LexLuthr
reviewed
Dec 21, 2023
| @@ -17,6 +17,7 @@ import ( | |||
| "github.com/filecoin-project/lotus/chain/types" | |||
| "github.com/ipfs/go-cid" | |||
| logging "github.com/ipfs/go-log/v2" | |||
| verifregtypes "github.com/filecoin-project/go-state-types/builtin/v9/verifreg" | |||
There was a problem hiding this comment.
Can you please check with v12 verifreg? We are trying to use latest actors as much as possible.
There was a problem hiding this comment.
Are you sure that will work? The v9 one is the one used in the return type of the API call
There was a problem hiding this comment.
Ahhh! Looks like a Lotus side dependency. Merging.
LexLuthr
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case (140.000 updates) shaves off 1.5 seconds per call (+ the load on the daemon) -> turns a 39 hour job into seconds