deps: FFI: update to version used by lotus v1.17.0-rc3 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
added a commit
that referenced
this pull request
Jul 21, 2022
* bump lotus dependency * deps: FFI: update to version used by lotus v1.17.0-rc3 (#654) * fix: dont use the gostream patch (#655) * deps: FFI: update to version used by lotus v1.17.0-rc3 * fix: use libp2p network stream instead of patched gostream Co-authored-by: Aayush <arajasek94@gmail.com> * update gostream to patch, revert stream changes * gen fix Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com> Co-authored-by: Jacob Heun <jacobheun@gmail.com>
LexLuthr
added a commit
that referenced
this pull request
Aug 3, 2022
…'s review] (#672) * bump lotus dependency * deps: FFI: update to version used by lotus v1.17.0-rc3 (#654) * fix: dont use the gostream patch (#655) * deps: FFI: update to version used by lotus v1.17.0-rc3 * fix: use libp2p network stream instead of patched gostream Co-authored-by: Aayush <arajasek94@gmail.com> * update gostream to patch, revert stream changes * gen fix * bump the version to v1.3.0-rc1 * gen and docsgen Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com> Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LexLuthr In general you want the version of FFI used by Boost to match the one used by the version of Lotus used by Boost. In this case Lotus v1.17.0-rc3 uses https://github.com/filecoin-project/filecoin-ffi/tree/98eeb1eb8e45967c8ac8108a466819cc072f0292, so this branch of Boost should too.
Haven't looked into the other CI failures, can if needed.