Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't allow go-merkledag to reorder loaded links #675

Merged
merged 2 commits into from
Aug 3, 2022
Merged

fix: don't allow go-merkledag to reorder loaded links #675

merged 2 commits into from
Aug 3, 2022

Commits on Aug 3, 2022

  1. fix: don't allow go-merkledag to reorder loaded links 

    Ref: #673 (comment)

Ideally we can remove go-merkledag entirely from here because most (all?) of
the deal-making infrastructure uses go-codec-dagpb + go-ipld-prime traversals
and post-decode link-reordering is a subtle difference that impacts CAR
ordering for non-spec-compliant DAG-PB blocks.
    @rvagg
    rvagg committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    3fe1cc0 View commit details
    Browse the repository at this point in the history

  2. test: add test for CarOffsetWriter dag traverse order

    @rvagg
    rvagg committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    9707212 View commit details
    Browse the repository at this point in the history