Add booster-bitswap request and response count metrics to dashboard #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehuntsman
force-pushed
the
kylehuntsman/booster-bitswap-stats
branch
from
6b52968
to
66f45cd
Compare
nonsense
reviewed
Oct 6, 2022
cmd/booster-bitswap/server.go
Outdated
| // Start the metrics web server | ||
| http.Handle("/metrics", metrics.Exporter("booster_bitswap")) // metrics server | ||
| go func() { | ||
| if err := http.ListenAndServe("0.0.0.0:1234", nil); err != nil { |
There was a problem hiding this comment.
LGTM, apart from using 1234 -- this is lotus daemon port.
We should use a free port, and have it configurable.
…away from bitswap server
nonsense
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setups the metrics infrastructure and adds metrics for booster-bitswap request and response counts for the
RemoteBlockstoreGet,Has, andGetSizefunctions to the monitoring Grafana dashboard. Adds counts for requests, and both success and fail responses. All counts show results over a 30 second interval.Code Changes
Startto0.0.0.0:1234/metricsendpointRemoteBlockstoreGet,Has, andGetSizeDashboard Changes
RemoteBlockstoreGet,Has, andGetSizeRemoteBlockstoreGet,Has, andGetSizeGet,Has, andGetSizefunction requests and responsesRemoteBlockstoreGet,Has, andGetSizefunction