Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce http api version #972

Merged
merged 1 commit into from
Nov 22, 2022
Merged

feat: introduce http api version #972

merged 1 commit into from
Nov 22, 2022

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Nov 21, 2022 •
edited
Loading

Fixes #966

jacobheun
jacobheun approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks correct. Will leave to @dirkmc or @nonsense to review the code.

Ideally we should version 0.2.0 with the changes to '/piece'. As long as that lands before this goes out in a 1.5.1 RC leaving as 0.2.0 wfm.

@LexLuthr LexLuthr requested a review from dirkmc November 21, 2022 13:03
@LexLuthr
Copy link
Collaborator Author

I am working on the /piece endpoint now. It will land soon.

dirkmc
dirkmc approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, test is concise and covers all new functionality, love it 🙌

@dirkmc dirkmc merged commit 313d0d2 into main Nov 22, 2022
@dirkmc dirkmc deleted the feat/http-version branch November 22, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an info endpoint to booster-http
3 participants
@LexLuthr @dirkmc @jacobheun