-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update current http urls as per #960 #975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we
- remove the
format
parameter from the /piece endpoint, as it can only ever have one value so it's redundant - remove all code related to building car files
- note that we should also remove any methods from HttpServerApi and its implementation that are no longer used
We can always find this code in the commit history if we need it later
ae75540
to
b55c938
Compare
@jacobheun Please let me know what's the final call on Dirk's comment. It makes sense to remove that param as it is not adding any value. |
@LexLuthr agreed on removing it as there's only 1 option. |
Let's remove PiecesContainingMultihash and GetMaxPieceOffset from HttpServerApi as they are no longer used. |
Fixes part of #960