Updates dependencies and tests for Synthetic PoRep support #1335
Conversation
|
Could you clarify the intention here? I don't think we want to merge any patches that target non-master branches into master here. If this is part of some complicated simultaneous upgrade scheme and only transient, is that written up somewhere? |
Thanks for asking. I'm ok with SynthPoRep targeting master across the board because we intend to ship it. For now, it was requested that I line everything up so that it could be tested end to end in a test network, so I opted to do that as branches across the entire stack. The intention is to NOT merge just yet, but allow the testing to continue. At some point later when it's deemed ok, I expect the merging to start. |
|
FWIW - i think this is ready to be reviewed and merged: FIP is accepted and scoped for nv21. & its tested e2e in lotus |
|
Please publish crates for the new dependencies and update Cargo.toml to pull them in with no patch directives. |
This doesn't add support for synthetic porep, but splits: #1335 Into two PRs.
* chore: update the fvm This doesn't add support for synthetic porep, but splits: #1335 Into two PRs. * finish update * I guess patches aren't enough * fix evm tests We now need to explicitly specify the sha3/ripemd features when testing (it was removed from shared). * fix clippy * switch back to helix master branch so that helix can pass CI again * use released helix crates
|
Closing in favor of #1409 |
Replaces #1331