Deprecate Deal IDs #1402

ZenGround0 · 2023-09-03T18:26:43Z

Stop writing deal ids into sector info upon commit
Improve the miner state check/summary framework to better work with cross market / miner check in the future

not yet following through on implementing the new market check, we need to construct the sector => deal index in market summary and then we can check the new live_data_sectors_map for inclusion of all sector numbers in the market index.

actors/miner/src/testing.rs

codecov-commenter · 2023-09-04T23:55:35Z

Codecov Report

❗ No coverage uploaded for pull request base (integration/direct-onboarding@1dc4975). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d3207a8 differs from pull request most recent head 60d12ed. Consider uploading reports for the commit 60d12ed to get more accurate results

Additional details and impacted files

@@                       Coverage Diff                        @@
##             integration/direct-onboarding    #1402   +/-   ##
================================================================
  Coverage                                 ?   90.51%           
================================================================
  Files                                    ?      146           
  Lines                                    ?    28166           
  Branches                                 ?        0           
================================================================
  Hits                                     ?    25495           
  Misses                                   ?     2671           
  Partials                                 ?        0

anorth

LGTM after minor changes.

anorth · 2023-09-05T00:42:38Z

actors/market/src/testing.rs

@@ -224,6 +224,7 @@ pub fn check_state_invariants<BS: Blockstore>(

    // pending proposals
    let mut pending_proposal_count = 0;
+    // XXX this is invalid, proposals are AMT not HAMT


This is pending proposals, which is a HAMT.

anorth · 2023-09-05T00:44:18Z

actors/miner/src/testing.rs

@@ -145,16 +145,18 @@ pub fn check_state_invariants<BS: Blockstore>(
 pub struct DealSummary {


Nit: rename to data summary?

anorth · 2023-09-05T00:45:51Z

integration_tests/src/tests/replica_update_test.rs

-    assert_eq!(1, new_sector_info_p1.deal_ids.len());
+    let duration = new_sector_info_p1.expiration - new_sector_info_p1.power_base_epoch;
+    let deal_weights1 = get_deal_weights(v, deal_ids[0], duration);
+    let deal_weights2 = get_deal_weights(v, deal_ids[1], duration);


Nit: move this line about sector2 down after 278

anorth · 2023-09-05T00:48:37Z

state/src/check.rs

-                claim.sector, maddr
-            ),
-        );
+        // XXX all claims are linked to a valid sector number


Please replace the XXX with a link to an issue, or just remove it and add a TODO item to #1342

anorth · 2023-09-05T00:49:42Z

I didn't spot the auto-merge before approving, but all good.

anorth · 2023-09-05T02:28:34Z

Applied my own comments in #1403

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

commit f0a0631 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Wed Jan 31 11:57:31 2024 +0400 emit event during settling payments commit a35b1cc Merge: 1722310 859c731 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 30 09:47:20 2024 +0400 Merge remote-tracking branch 'origin/master' into feat/ddo-actor-events commit 1722310 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Mon Jan 29 14:04:27 2024 +0400 Apply suggestions from code review Co-authored-by: Rod Vagg <rod@vagg.org> commit b149550 Merge: 803f420 d0b8d9c Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Mon Jan 29 14:00:12 2024 +0400 Merge remote-tracking branch 'origin/integration/manual-settlement' into feat/ddo-actor-events commit d0b8d9c Author: Alex Su <alexanderytsu@gmail.com> Date: Mon Oct 16 09:09:28 2023 +1100 Use ExitCode::USR_NOT_FOUND for missing state in GetDealActivation (#1441) * hide deals that are asynchronously termianted in get_deal_activation * add test for EX_DEAL_EXPIRED behaviour commit c6227a2 Author: Alex Su <alexanderytsu@gmail.com> Date: Mon Oct 9 13:00:46 2023 +1100 Additional tests for synchronous termination and SettleDealPayments (#1423) * rename some tests and comments to no longer reference slashed_epoch which will never be observable * port cron tick tests for deal termination * move deal termination tests * modify generate and publish deal to return proposal inline * fix bug when settling payments between between publish and activation * deal termination edge cases * pr review commit 21baa60 Author: Alex Su <alexanderytsu@gmail.com> Date: Fri Sep 8 12:29:14 2023 +1000 Explicit deal settlement in built-in market (#1377) commit 803f420 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 23 18:21:17 2024 +0400 changes commit 78ec9f6 Merge: c90fafe e671d69 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 23 18:21:02 2024 +0400 Merge remote-tracking branch 'origin/integration/direct-onboarding' into feat/ddo-actor-events commit e671d69 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Jan 23 14:07:21 2024 +1300 More review response for #1486. (#1508) commit db65674 Author: Steven Allen <steven@stebalien.com> Date: Wed Jan 17 10:56:30 2024 -0800 Cleanup batch return merge logic (#1503) This just avoids some awkward unwraps. commit 84b0c00 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Wed Jan 17 09:05:16 2024 +1300 Response to review on #1486 (#1499) Response to review on #1486 commit 049b9c7 Author: Steven Allen <steven@stebalien.com> Date: Mon Jan 15 12:48:17 2024 -0800 chore: remove unnecessary clone of piece payload (#1494) commit 9334a87 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Jan 9 07:04:12 2024 +1300 Add aggregate proof type parameter to ProveCommitSectors3 (#1489) commit 4126ccb Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Dec 22 07:17:28 2023 +1100 Add missing vm_test annotations. (#1488) commit 3ad21ac Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Dec 19 11:49:23 2023 +1100 Rename PCS2/PRU2 to PCS3/PRU3 (#1485) commit 53cb47e Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Dec 19 11:08:21 2023 +1100 Transparent serialization for ProveReplicaUpdates2Return (#1484) commit 5cdfc2f Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 31 13:49:37 2023 +1100 Integration test for prove_replica_updates2 (#1453) commit 0f8c593 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 31 12:52:33 2023 +1100 Integration test for prove_commit_sectors2 (#1450) commit 5cecdf6 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 31 11:52:06 2023 +1100 Add GetDealSector exported API method to market actor (#1443) commit 21c01a9 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 17 05:20:35 2023 +1100 More tests for direct data onboarding (#1440) Tests that CommD computed from pieces must match that declared at precommit. Tests that updating an empty replica to be empty is permitted (later, when we allow updates to non-empty replicas, it won't be a no-op). commit 47e1cf1 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Mon Oct 16 07:18:28 2023 +1100 Tests for prove_commit_sectors2 (#1437) commit a108360 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Thu Sep 28 03:11:22 2023 +1000 Tests for ProveCommitSectors2 for cases that abort entirely (#1414) commit ff66f79 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Sat Sep 23 05:05:35 2023 +1000 Check state invariants in direct onboarding tests (#1416) commit 3354d8a Author: Alex North <445306+anorth@users.noreply.github.com> Date: Sat Sep 16 04:23:58 2023 +1000 Tests and fixes for ProveReplicaUpdates2 (#1411) * Tests and fixes for ProveReplicaUpdates2 * Helper function commit 869af32 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Mon Sep 11 10:17:48 2023 +1000 Move prove_commit2 tests to separate file from pru tests (#1410) commit 24b5cd6 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Sep 8 10:19:52 2023 +1000 PRU2 tests that abort the whole method (#1407) commit ff472f2 Author: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Date: Thu Sep 7 19:04:58 2023 -0400 Prove commit 2 simple tests (#1408) commit a861f02 Author: Shrenuj Bansal <108157875+shrenujbansal@users.noreply.github.com> Date: Wed Sep 6 21:47:36 2023 -0400 Return error if success count for proof validation or data activations is 0 (#1406) commit 0457d86 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Wed Sep 6 08:26:36 2023 +1000 Remove allocation id from market deal state. Clean up and improve state checks. (#1403) commit e0083f4 Author: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Date: Mon Sep 4 20:48:54 2023 -0400 Deprecate Deal IDs (#1402) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit d78586f Author: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Date: Mon Sep 4 14:44:41 2023 -0400 Deprecate unused Prove Replica update 2 (#1401) * Simplify input to activate_sectors_deals * Remove old PRU2 and parameter types * Reuse PRU2 name for DDO PRU fka PRU 3 --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit c1aa98f Author: Alex North <445306+anorth@users.noreply.github.com> Date: Mon Sep 4 11:09:24 2023 +1000 Basic unit tests for ProveReplicaUpdate3 (#1394) commit 5de9cae Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Sep 1 08:24:52 2023 +1000 Compute batch returns for direct onboarding methods (#1393) commit 06f282a Author: Alex North <445306+anorth@users.noreply.github.com> Date: Thu Aug 31 05:10:48 2023 +1000 Send SectorContentChanged from new onboarding methods (#1386) Send SectorContentChanged from new onboarding methods. Simplify return values to make notifications fire and forget. commit 6a2a089 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Thu Aug 31 03:43:37 2023 +1000 Miner notifies market of termination only of sectors with non-zero data (#1387) Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> commit ba9b579 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Wed Aug 30 20:07:45 2023 +1000 Implement new ProveReplicaUpdates3 for direct data onboarding. (#1385) commit 9c681c7 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Aug 29 08:38:39 2023 +1000 Implements new ProveCommit batch+aggregate for direct onboarding (#1380) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit c5fd304 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Aug 15 13:35:08 2023 +1000 Implements SectorContentChanged method in built-in market actor (#1353) commit e55498d Author: Alex North <445306+anorth@users.noreply.github.com> Date: Wed Aug 9 08:40:52 2023 +1000 Remove deprecated precommit methods (#1357) - PreCommitSector and PreCommitBatch deprecated - PreCommitBatchV2 now requires specifying (compact) CommD - Move all testing to use PreCommitBatchV2 Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit 181305e Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Aug 4 04:33:49 2023 +1000 Implement sector->deal mapping in built-in market actor (#1347) commit c90fafe Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Thu Jan 18 20:06:10 2024 +0400 changes as per steb's review commit 7e0abca Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Jan 12 11:24:13 2024 +1300 Simply deal activation return and intermediate data flow commit 6e3b5ca Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Thu Jan 11 21:41:05 2024 +0400 finish review commit 4d20e04 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Thu Jan 11 18:28:23 2024 +0400 tests pass commit 733a98f Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Wed Jan 10 17:51:41 2024 +0400 fix itests commit aef0fdd Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Wed Jan 10 17:21:41 2024 +0400 batch activate deals should return piece info commit 4a1ecdf Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 9 19:59:35 2024 +0400 rustfmt commit f92222d Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 9 19:53:59 2024 +0400 itests green commit 6f8be0d Merge: 693338f aa0a168 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 9 17:28:53 2024 +0400 Merge remote-tracking branch 'origin/integration/direct-onboarding' into feat/ddo-actor-events commit 693338f Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 9 17:25:36 2024 +0400 itests almost there commit aa0a168 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Jan 9 07:04:12 2024 +1300 Add aggregate proof type parameter to ProveCommitSectors3 (#1489) commit 9e19d32 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Mon Jan 8 19:32:09 2024 +0400 itests partially complete commit 0485317 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Mon Jan 8 17:09:44 2024 +0400 itests work 1 commit 2ce92e6 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Mon Jan 8 14:29:03 2024 +0400 miner actor events commit 9a22c67 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Wed Jan 3 12:48:36 2024 +0400 miner actor events commit 6e5d70c Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 2 13:15:42 2024 +0400 market actor events commit f522274 Author: Aarsh Shah <aarshkshah1992@gmail.com> Date: Tue Jan 2 10:02:11 2024 +0400 verifreg events and itest harness commit 1d85ec5 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Dec 22 07:17:28 2023 +1100 Add missing vm_test annotations. (#1488) commit 0d103fe Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Dec 19 11:49:23 2023 +1100 Rename PCS2/PRU2 to PCS3/PRU3 (#1485) commit e01a799 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Dec 19 11:08:21 2023 +1100 Transparent serialization for ProveReplicaUpdates2Return (#1484) commit 13931e0 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 31 13:49:37 2023 +1100 Integration test for prove_replica_updates2 (#1453) commit 39b488b Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 31 12:52:33 2023 +1100 Integration test for prove_commit_sectors2 (#1450) commit 04f3843 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 31 11:52:06 2023 +1100 Add GetDealSector exported API method to market actor (#1443) commit e48433c Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Oct 17 05:20:35 2023 +1100 More tests for direct data onboarding (#1440) Tests that CommD computed from pieces must match that declared at precommit. Tests that updating an empty replica to be empty is permitted (later, when we allow updates to non-empty replicas, it won't be a no-op). commit 7dfdfc2 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Mon Oct 16 07:18:28 2023 +1100 Tests for prove_commit_sectors2 (#1437) commit df2711e Author: Alex North <445306+anorth@users.noreply.github.com> Date: Thu Sep 28 03:11:22 2023 +1000 Tests for ProveCommitSectors2 for cases that abort entirely (#1414) commit 3f3a6c4 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Sat Sep 23 05:05:35 2023 +1000 Check state invariants in direct onboarding tests (#1416) commit c9fdbaa Author: Alex North <445306+anorth@users.noreply.github.com> Date: Sat Sep 16 04:23:58 2023 +1000 Tests and fixes for ProveReplicaUpdates2 (#1411) * Tests and fixes for ProveReplicaUpdates2 * Helper function commit 6ef0eb2 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Mon Sep 11 10:17:48 2023 +1000 Move prove_commit2 tests to separate file from pru tests (#1410) commit 5f28bc2 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Sep 8 10:19:52 2023 +1000 PRU2 tests that abort the whole method (#1407) commit 415bc7a Author: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Date: Thu Sep 7 19:04:58 2023 -0400 Prove commit 2 simple tests (#1408) commit d3e7256 Author: Shrenuj Bansal <108157875+shrenujbansal@users.noreply.github.com> Date: Wed Sep 6 21:47:36 2023 -0400 Return error if success count for proof validation or data activations is 0 (#1406) commit aaca941 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Wed Sep 6 08:26:36 2023 +1000 Remove allocation id from market deal state. Clean up and improve state checks. (#1403) commit 2724624 Author: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Date: Mon Sep 4 20:48:54 2023 -0400 Deprecate Deal IDs (#1402) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit fbbdaf8 Author: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Date: Mon Sep 4 14:44:41 2023 -0400 Deprecate unused Prove Replica update 2 (#1401) * Simplify input to activate_sectors_deals * Remove old PRU2 and parameter types * Reuse PRU2 name for DDO PRU fka PRU 3 --------- Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit 4b9042b Author: Alex North <445306+anorth@users.noreply.github.com> Date: Mon Sep 4 11:09:24 2023 +1000 Basic unit tests for ProveReplicaUpdate3 (#1394) commit 3a293df Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Sep 1 08:24:52 2023 +1000 Compute batch returns for direct onboarding methods (#1393) commit 351a15a Author: Alex North <445306+anorth@users.noreply.github.com> Date: Thu Aug 31 05:10:48 2023 +1000 Send SectorContentChanged from new onboarding methods (#1386) Send SectorContentChanged from new onboarding methods. Simplify return values to make notifications fire and forget. commit 35efa32 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Thu Aug 31 03:43:37 2023 +1000 Miner notifies market of termination only of sectors with non-zero data (#1387) Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> commit 8dd2c12 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Wed Aug 30 20:07:45 2023 +1000 Implement new ProveReplicaUpdates3 for direct data onboarding. (#1385) commit 079ebbc Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Aug 29 08:38:39 2023 +1000 Implements new ProveCommit batch+aggregate for direct onboarding (#1380) Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit 047c3ec Author: Alex North <445306+anorth@users.noreply.github.com> Date: Tue Aug 15 13:35:08 2023 +1000 Implements SectorContentChanged method in built-in market actor (#1353) commit 3e14b94 Author: Alex North <445306+anorth@users.noreply.github.com> Date: Wed Aug 9 08:40:52 2023 +1000 Remove deprecated precommit methods (#1357) - PreCommitSector and PreCommitBatch deprecated - PreCommitBatchV2 now requires specifying (compact) CommD - Move all testing to use PreCommitBatchV2 Co-authored-by: ZenGround0 <5515260+ZenGround0@users.noreply.github.com> Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com> commit dd3b68e Author: Alex North <445306+anorth@users.noreply.github.com> Date: Fri Aug 4 04:33:49 2023 +1000 Implement sector->deal mapping in built-in market actor (#1347)

ZenGround0 force-pushed the feat/no-more-deal-ids branch from ecd81d7 to ab225c3 Compare September 3, 2023 19:10

anorth mentioned this pull request Sep 3, 2023

Implement FIP-0076 Direct data onboarding #1342

Closed

anorth reviewed Sep 3, 2023

View reviewed changes

actors/miner/src/testing.rs Show resolved Hide resolved

Deprecated sector info deal_ids field

3e9ae78

ZenGround0 force-pushed the feat/no-more-deal-ids branch from ab225c3 to 3e9ae78 Compare September 4, 2023 19:00

ZenGround0 added 2 commits September 4, 2023 14:18

Tests building

63992dd

Fix incorrect deal weight calculation for tests

55f3f7a

ZenGround0 marked this pull request as ready for review September 4, 2023 23:00

ZenGround0 enabled auto-merge (squash) September 4, 2023 23:00

ZenGround0 requested a review from anorth September 4, 2023 23:00

Review Response

60d12ed

ZenGround0 force-pushed the feat/no-more-deal-ids branch from d3207a8 to 60d12ed Compare September 4, 2023 23:03

anorth approved these changes Sep 5, 2023

View reviewed changes

ZenGround0 merged commit 4baeb38 into integration/direct-onboarding Sep 5, 2023

ZenGround0 deleted the feat/no-more-deal-ids branch September 5, 2023 00:48

anorth pushed a commit that referenced this pull request Dec 12, 2023

Deprecate Deal IDs (#1402)

40b5045

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

anorth pushed a commit that referenced this pull request Dec 12, 2023

Deprecate Deal IDs (#1402)

2436b1d

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

anorth pushed a commit that referenced this pull request Dec 14, 2023

Deprecate Deal IDs (#1402)

e494326

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

anorth pushed a commit that referenced this pull request Dec 14, 2023

Deprecate Deal IDs (#1402)

2724624

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

anorth pushed a commit that referenced this pull request Jan 22, 2024

Deprecate Deal IDs (#1402)

e0083f4

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

anorth pushed a commit that referenced this pull request Jan 23, 2024

Deprecate Deal IDs (#1402)

29dc891

Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>

Terryhung mentioned this pull request Apr 25, 2024

feat: add new task miner sector deal v2 filecoin-project/lily#1293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate Deal IDs #1402

Deprecate Deal IDs #1402

ZenGround0 commented Sep 3, 2023

codecov-commenter commented Sep 4, 2023 •

edited

Loading

anorth left a comment

anorth Sep 5, 2023

anorth Sep 5, 2023

anorth Sep 5, 2023

anorth Sep 5, 2023

anorth commented Sep 5, 2023

anorth commented Sep 5, 2023

		@@ -145,16 +145,18 @@ pub fn check_state_invariants<BS: Blockstore>(
		pub struct DealSummary {

Deprecate Deal IDs #1402

Deprecate Deal IDs #1402

Conversation

ZenGround0 commented Sep 3, 2023

codecov-commenter commented Sep 4, 2023 • edited Loading

Codecov Report

anorth left a comment

Choose a reason for hiding this comment

anorth Sep 5, 2023

Choose a reason for hiding this comment

anorth Sep 5, 2023

Choose a reason for hiding this comment

anorth Sep 5, 2023

Choose a reason for hiding this comment

anorth Sep 5, 2023

Choose a reason for hiding this comment

anorth commented Sep 5, 2023

anorth commented Sep 5, 2023

codecov-commenter commented Sep 4, 2023 •

edited

Loading