[m2 native] user actor installation #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failures are from the newly added transitive feature for m2-native. This is implemented in re-fvm#658, so once that merges we can point the dep to ref-fvm master and cargo lock till release. |
raulk
reviewed
Jul 21, 2022
Comment on lines
+51
to
+59
| [patch.crates-io] | ||
| ## TODO point this to master | ||
| fvm_shared = { git = "https://github.com/filecoin-project/ref-fvm" } | ||
| fvm_sdk = { git = "https://github.com/filecoin-project/ref-fvm" } | ||
| fvm_ipld_hamt = { git = "https://github.com/filecoin-project/ref-fvm" } | ||
| fvm_ipld_amt = { git = "https://github.com/filecoin-project/ref-fvm" } | ||
| fvm_ipld_bitfield = { git = "https://github.com/filecoin-project/ref-fvm" } | ||
| fvm_ipld_encoding = { git = "https://github.com/filecoin-project/ref-fvm" } | ||
| fvm_ipld_blockstore = { git = "https://github.com/filecoin-project/ref-fvm" } |
There was a problem hiding this comment.
I'm not sure if patches work with bundles -- have you tested this @vyzo? BTW -- It can be updated now since the upstream PR is merged in ref-fvm.
There was a problem hiding this comment.
It points to master, once we have a release we can update.
cargo build works fine, why would the bundles fail?
There was a problem hiding this comment.
make bundle-devnet seems to work fine.
This was referenced Jul 27, 2022
Closed
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings #216 into next, feature gated by m2-native.
TODO: