EVM Precompiles #564
Merged
EVM Precompiles #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Aug 19, 2022
…tion state for memory functions
Stebalien
reviewed
Aug 24, 2022
|
This will need a rebase once #575 merges, there are quite a few changes in the interpreter. |
mriise
commented
Aug 26, 2022
vyzo
approved these changes
Aug 26, 2022
Stebalien
reviewed
Sep 2, 2022
| PRECOMPILES[precompile_addr.0[0] as usize - 1](input) | ||
| pub struct Precompiles<BS, RT>(PhantomData<BS>, PhantomData<RT>); | ||
|
|
||
| impl<BS: Blockstore, RT: Runtime<BS>> Precompiles<BS, RT> { |
| fn fixed_hasher(offset: ChainEpoch) -> Box<dyn Fn(&[u8]) -> [u8; 32]> { | ||
| let hash = move |_: &[u8]| -> [u8; 32] { | ||
| let mut result = [0u8; 32]; | ||
| fn fixed_hasher(offset: ChainEpoch) -> Box<dyn Fn(SupportedHashes, &[u8]) -> ([u8; 64], usize)> { |
There was a problem hiding this comment.
Hm. What's the max digest length in the EVM?
There was a problem hiding this comment.
32 bytes, but our hash function can do up to 64 bytes
Stebalien
approved these changes
Sep 2, 2022
Co-authored-by: Steven Allen <steven@stebalien.com>
9 tasks
9 tasks
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Oct 3, 2022
* add precompiles from old branc evm-precompiles * move precompiles file, add blake2 dep with blake2f * wip call fn, use precompile error type * use u256 instead of raw bytes (cleans up code) * remove Message struct as is no longer needed * attempt getting input & output memory regions * dont use custom error type, pass in just memory instead of full execution state for memory functions * write output back into smart contract remove old TODOs * add blake2f precompile * edit TODOs * rustfmt * add modxp precompile & remove gas limit/accouting for precompiles * add expairing, use custom error type, remove gas accounting, replace unsafe code * cleanup unused things and rename precompile error variant * use fork for blakef2, organize precompiles in file * move static call type to enum * add warnings and use different slicing method * rustfmt * fix errors from merge * use InvalidMemAccess again instead of OutOfGas * lock ref-fvm to specific hash to avoid Token struct changes * go back to normal EVM precompile addresssing, unlock ref-fvm version hash * add blake2 and ec ops precompile tests * fix precompile test errors issues * Update precompiles - use methods on runtime for syscalls instead of importing SDK - fix broken tests - fix some EC methods that would expect empty bytes instead of error * implement hash and recover pubkey in tests * import sepc consts * rustfmt & clippy * Update actors/evm/src/interpreter/precompiles.rs Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: Steven Allen <steven@stebalien.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous PRs: #553, #563
tracking issue: filecoin-project/ref-fvm#695
doesnt have the glue yet for redirecting a normal call