feat: enum-based opcodes #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Aug 23, 2022
Stebalien
commented
- removes the explicit instruction array.
- removes the undefined instructions.
- removes the need for ordering instructions in a specific way.
- ensures that we can't talk about invalid instructions.
- removes the explicit instruction array. - removes the undefined instructions. - removes the need for ordering instructions in a specific way. - ensures that we can't talk about invalid instructions.
vyzo
approved these changes
Aug 23, 2022
| return Err(StatusCode::UndefinedInstruction); | ||
| } | ||
|
|
||
| Ok(unsafe { std::mem::transmute(op) }) |
There was a problem hiding this comment.
haha, you need this to do anything interesting in this language ;)
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Oct 3, 2022
- removes the explicit instruction array. - removes the undefined instructions. - removes the need for ordering instructions in a specific way. - ensures that we can't talk about invalid instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.