EVM runtime: implement some contextual opcodes + EVM Address type #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
force-pushed
the
raulk/contextual-opcodes
branch
from
faf71cb
to
b3ed287
Compare
vyzo
approved these changes
Aug 30, 2022
| use crate::U256; | ||
| use fvm_shared::address::Address as FilecoinAddress; | ||
|
|
||
| /// A Filecoin ad dress as represented in the FEVM runtime. |
There was a problem hiding this comment.
nit: unnecessary spaces in ad dress
mriise
approved these changes
Aug 30, 2022
Stebalien
approved these changes
Aug 30, 2022
Make CALLER, ADDRESS, ORIGIN use masked ID addresses.
Stebalien
approved these changes
Sep 1, 2022
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Oct 3, 2022
…lecoin-project#586) * refactor: move opcode handlers to appropriate modules. * implement BASEFEE opcode handler. * implement SELFBALANCE opcode handler. * EVM runtime: add an initial Address type that performs ID address masking. * EVM runtime: convert EVM errors to ActorErrors. * EVM runtime: commented selfdestruct. * EVM runtime: implement DIFFICULTY, NUMBER, COINBASE opcodes. * EVM runtime: add conversion from actor ID to masked address. Make CALLER, ADDRESS, ORIGIN use masked ID addresses. * remove TODO. * add comment. * fix clippy. * adjust test for ID address flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl From<ActorError> for StatusCodeerror conversion.Partly covers filecoin-project/ref-fvm#689.
Closes filecoin-project/ref-fvm#821.