feat: update sdk & shared for TokenAmount and hashing changes #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Aug 30, 2022
actors/market/src/testing.rs
Outdated
| @@ -90,7 +90,8 @@ pub fn check_state_invariants<BS: Blockstore + Debug>( | |||
| match DealArray::load(&state.proposals, store) { | |||
| Ok(proposals) => { | |||
| let ret = proposals.for_each(|deal_id, proposal| { | |||
| let proposal_cid = proposal.cid()?; | |||
| //let proposal_cid = proposal.cid()?; | |||
| let proposal_cid = todo!(); | |||
There was a problem hiding this comment.
Need the runtime to call deal_cid. We'll probably need to explicitly compute the blake2b hash here.
Stebalien
force-pushed
the
feat/update-sdk
branch
3 times, most recently
from
9c5cbdf
to
ec5ce00
Compare
|
Depends on filecoin-project/ref-fvm#819. |
Stebalien
force-pushed
the
feat/update-sdk
branch
2 times, most recently
from
716a71d
to
bfc5b95
Compare
|
I still need to fix the proposal CID thing, but the TokenAmount changes are ready for review. If you want to test, I strongly suggest that you checkout the backport/token-ops ref-fvm branch locally, and uncomment the local patch. The git-based "patch" will clone some very large git submodules, and there's no way to tell cargo to not do that at the moment. |
Stebalien
force-pushed
the
feat/update-sdk
branch
5 times, most recently
from
19fc1e9
to
3c25d0e
Compare
Stebalien
changed the title
Stebalien
force-pushed
the
feat/update-sdk
branch
from
3c25d0e
to
2a8d3d5
Compare
Stebalien
force-pushed
the
feat/update-sdk
branch
from
2a8d3d5
to
da26a0b
Compare
Stebalien
force-pushed
the
feat/update-sdk
branch
from
da26a0b
to
8d8150c
Compare
mriise
approved these changes
Aug 31, 2022
Rust _usually_ catches this kind of thing, but apparently not inside a lazy_static.
We don't need these now that we have extra Mul impls.
Stebalien
force-pushed
the
feat/update-sdk
branch
from
d29330e
to
60b4621
Compare
Stebalien
added a commit
that referenced
this pull request
Aug 31, 2022
Stebalien
added a commit
that referenced
this pull request
Aug 31, 2022
anorth
reviewed
Aug 31, 2022
| @@ -108,12 +107,9 @@ pub struct DealProposal { | |||
| // otherwise it is invalid. | |||
| pub start_epoch: ChainEpoch, | |||
| pub end_epoch: ChainEpoch, | |||
| #[serde(with = "bigint_ser")] | |||
Stebalien
added a commit
that referenced
this pull request
Aug 31, 2022
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Oct 3, 2022
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.