Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document easy way for Xeon processors to build #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snadrus
Copy link
Contributor

@snadrus snadrus commented Aug 14, 2024

No description provided.

@snadrus snadrus requested a review from LexLuthr August 14, 2024 22:29
@snadrus snadrus enabled auto-merge (squash) August 14, 2024 22:30
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one nit

@@ -159,6 +159,11 @@ git checkout <release version>
export CGO_CFLAGS="-D__BLST_PORTABLE__"
```

3. Also for old processors, if Curio cannot start because the processor generation is too old, add the variable:\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Also for old processors, if Curio cannot start because the processor generation is too old, add the variable:\
3. Also for old processors, if Curio cannot start because the processor generation is too old, add the variable and rebuild the binaries:\

Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we auto-detect maybe?

Something like

ifeq ($(shell grep -q avx512f /proc/cpuinfo && echo yes),yes)
    export GOAMD64 := v3
else
    export GOAMD64 := v1
endif

@LexLuthr
Copy link
Contributor

Auto detect might be a better way instead of docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants