Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lmrpc: Maintain local piecerefs #178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

lmrpc: Maintain local piecerefs #178

wants to merge 3 commits into from

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Aug 27, 2024 •
edited
Loading

This should fix all known issues with PiecePark

  • When pieces-refs are created but fail to park, piece refs will now get removed correctly
    • This also fixes the issue when the PiecePark task can fail with EOF.. due to stale URLs in stale piece_refs
  • Don't assume that data is only read from the first piece
  • Correctly remove piece_refs which don't end up added to a sector
  • Cleanup orphaned piece_refs on startup
    • This should cleanup all mess accumulated by existing nodes
  • Fix an edge-case where a piece_ref could be added to a piece which is currently getting removed

@magik6k magik6k requested a review from LexLuthr August 27, 2024 19:31
@magik6k
Copy link
Collaborator Author

magik6k commented Sep 16, 2024

NOTE: This PR won't land in main, but will be open until we land Curio-native markets.

Curio markets won't require this fix, and it is a little conflicting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr Awaiting requested review from LexLuthr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@magik6k