feat: create http server #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Sep 4, 2024
magik6k
reviewed
Sep 4, 2024
magik6k
reviewed
Sep 4, 2024
magik6k
approved these changes
Sep 6, 2024
Comment on lines
+578
to
+579
| // WriteTimeout is the maximum duration before timing out writes of the response to the client. | ||
| WriteTimeout time.Duration |
There was a problem hiding this comment.
Are we later able to set this higher for responses from e.g. the /piece endpoint?
There was a problem hiding this comment.
Yes. I will try to find better write defaults once this is merged. More practical ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a HTTPS server to Curio market.
The autocert cache is stored in DB instead of a directory which can be access by all nodes.