This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
adapt for binary outputs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this patch also removes the JSON wrapper around the results that specify the job number and that it succeeded. The job number is in the filename, and the fact that it succeeded is basically evident from all the expected output data being there, so I think it's not worth the container. |
whyrusleeping
approved these changes
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My binary output from the simulator is getting corrupted while passing through “fungi”. I poked at it with a hex differ, and there’s a lot of data being replaced by EFBFBD sequences. Googling “go EFBFBD” yields go-ipfs/issues#3522. Just the folks I wanted to see! @whyrusleeping @dignifiedquire Here's the fix in fungi. CC @zixuanzh