Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve push channel to detect when not all data has been received #157

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 10, 2021

Fixes #153
Implements the Push Channel tests for #154

@dirkmc dirkmc force-pushed the test/auto-restart-push branch 2 times, most recently from 3ed5718 to e9b629e Compare March 11, 2021 16:35
@dirkmc dirkmc changed the title Add tests for auto-restarting a push channel Improve push channel to detect when not all data has been received Mar 12, 2021
@dirkmc dirkmc marked this pull request as ready for review March 12, 2021 09:09
@dirkmc dirkmc requested review from nonsense and raulk March 12, 2021 09:09
Copy link
Member

@nonsense nonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm!

@dirkmc dirkmc merged commit 42e0a5b into master Mar 15, 2021
@dirkmc dirkmc deleted the test/auto-restart-push branch March 15, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push channel monitor doesn't detect when not all data received
2 participants