update to context datastores #283
Conversation
whyrusleeping
requested review from
dirkmc,
Stebalien,
aarshkshah1992 and
arajasek
| @@ -422,6 +422,11 @@ func (fgs *FakeGraphSync) Stats() graphsync.Stats { | |||
| return graphsync.Stats{} | |||
| } | |||
|
|
|||
| func (fgs *FakeGraphSync) RegisterOutgoingRequestProcessingListener(graphsync.OnOutgoingRequestProcessingListener) graphsync.UnregisterHookFunc { | |||
There was a problem hiding this comment.
where this came from why this exist
There was a problem hiding this comment.
yea that's a mock GraphExchange interface that needs a new method cause Graphsync updated and added it.. I'm moving away from putting methods on GraphExchange and towards only implementing them on the main implementation to simplify this. But later.
|
Updated to latest go-ds-versioning, but test seems to be flaky failing (passes locally) |
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 67.58% 67.50% -0.09%
==========================================
Files 24 24
Lines 3184 3188 +4
==========================================
Hits 2152 2152
- Misses 668 671 +3
- Partials 364 365 +1
Continue to review full report at Codecov.
|
| @@ -422,6 +422,11 @@ func (fgs *FakeGraphSync) Stats() graphsync.Stats { | |||
| return graphsync.Stats{} | |||
| } | |||
|
|
|||
| func (fgs *FakeGraphSync) RegisterOutgoingRequestProcessingListener(graphsync.OnOutgoingRequestProcessingListener) graphsync.UnregisterHookFunc { | |||
There was a problem hiding this comment.
yea that's a mock GraphExchange interface that needs a new method cause Graphsync updated and added it.. I'm moving away from putting methods on GraphExchange and towards only implementing them on the main implementation to simplify this. But later.
No description provided.