Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deal state channel id nilable #490

Merged
merged 3 commits into from
Feb 24, 2021
Merged

make deal state channel id nilable #490

merged 3 commits into from
Feb 24, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Feb 17, 2021

Addresses filecoin-project/go-data-transfer#143

TODO:

  • ClientDealState
  • ProviderDealState

@codecov-io
Copy link

Codecov Report

Merging #490 (dc2b0bc) into master (e50bca4) will increase coverage by 0.17%.
The diff coverage is 88.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   65.16%   65.32%   +0.17%     
==========================================
  Files          50       51       +1     
  Lines        3266     3408     +142     
==========================================
+ Hits         2128     2226      +98     
- Misses        912      954      +42     
- Partials      226      228       +2     
Impacted Files Coverage Δ
...etrievalmarket/impl/providerstates/provider_fsm.go 6.46% <0.00%> (ø)
retrievalmarket/types.go 41.47% <ø> (ø)
...rievalmarket/impl/requestvalidation/revalidator.go 76.23% <22.23%> (-3.33%) ⬇️
retrievalmarket/impl/client.go 68.40% <100.00%> (ø)
retrievalmarket/impl/clientstates/client_fsm.go 74.34% <100.00%> (ø)
retrievalmarket/impl/clientstates/client_states.go 92.41% <100.00%> (+0.10%) ⬆️
...ievalmarket/impl/providerstates/provider_states.go 90.70% <100.00%> (+0.46%) ⬆️
retrievalmarket/migrations/migrations.go 71.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50bca4...dc2b0bc. Read the comment docs.

@dirkmc dirkmc requested a review from nonsense February 18, 2021 09:56
Copy link
Member

@nonsense nonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
@dirkmc dirkmc merged commit d1405ef into master Feb 24, 2021
@dirkmc dirkmc deleted the feat/deal-state-chid-nil branch February 24, 2021 13:00
@dirkmc dirkmc mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants