-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-graphsync v0.8.0 #552
Conversation
Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
ff91033
to
817827c
Compare
FYI: Reason for updating extern/filecoin-ffi (to same as on LOTUS) is that I have a Mac with an M1 processor, and the very old version we had was built with a version of Rust that didn't support the architecture. Which then required an update to circleci config so it would compile. Ridiculous I know. |
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 65.55% 65.63% +0.08%
==========================================
Files 56 56
Lines 3750 3750
==========================================
+ Hits 2458 2461 +3
+ Misses 1045 1039 -6
- Partials 247 250 +3
Continue to review full report at Codecov.
|
…hsync-v0.8.0_to_1.5.0 Feat/update update graphsync v0.8.0 to 1.5.0
Superseded by #615 |
Goals
Good news: The latest version of go-graphync and go-ipld-prime contains an important optimization to remove a bunch of unneccesary hashing when reading from local blockstores, which should cut down significantly on CPU usage
Bad news: The latest versions of these libraries contain a some important, but very breaking changes to syntax.
Good news: I'm updating them all the way to Lotus! And also, in most cases, from the point of view of the consuming libraries, they're simplifications.
Implementation
Background
For Discussion
Merge Blocked ON:
filecoin-project/go-data-transfer#212
filecoin-project/go-multistore#3