Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-graphsync v0.8.0 #552

Closed
wants to merge 6 commits into from
Closed

Conversation

hannahhoward
Copy link
Collaborator

Goals

Good news: The latest version of go-graphync and go-ipld-prime contains an important optimization to remove a bunch of unneccesary hashing when reading from local blockstores, which should cut down significantly on CPU usage
Bad news: The latest versions of these libraries contain a some important, but very breaking changes to syntax.
Good news: I'm updating them all the way to Lotus! And also, in most cases, from the point of view of the consuming libraries, they're simplifications.

Implementation

  • Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
  • Update other dependent libraries with SHA updates
  • Fix syntax changes which are mostly to:
    • dagcbor Encode / Decode function name
    • use of linksystem over loader + storer.

Background

For Discussion

Merge Blocked ON:
filecoin-project/go-data-transfer#212
filecoin-project/go-multistore#3

Update to go-graphsync v0.8.0 with go-ipld-prime linksystem branch & trusted store.
@hannahhoward
Copy link
Collaborator Author

FYI:

Reason for updating extern/filecoin-ffi (to same as on LOTUS) is that I have a Mac with an M1 processor, and the very old version we had was built with a version of Rust that didn't support the architecture. Which then required an update to circleci config so it would compile.

Ridiculous I know.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #552 (2d660f8) into master (32e5cce) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   65.55%   65.63%   +0.08%     
==========================================
  Files          56       56              
  Lines        3750     3750              
==========================================
+ Hits         2458     2461       +3     
+ Misses       1045     1039       -6     
- Partials      247      250       +3     
Impacted Files Coverage Δ
retrievalmarket/common.go 66.67% <100.00%> (ø)
retrievalmarket/impl/dtutils/dtutils.go 79.44% <100.00%> (ø)
...market/impl/requestvalidation/requestvalidation.go 87.66% <100.00%> (ø)
retrievalmarket/types.go 57.15% <100.00%> (ø)
storagemarket/impl/dtutils/dtutils.go 75.00% <100.00%> (ø)
storagemarket/impl/provider.go 26.53% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e5cce...2d660f8. Read the comment docs.

@hannahhoward
Copy link
Collaborator Author

Superseded by #615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants