Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add storage group documentation under seal-workers #32

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Dec 2, 2021

Fixes #30

The documentation details how storage groups can be used to reduce the data movement by assigning the sealing steps to a fixed group of nodes with access to already processed data.

Copy link
Contributor

@johnnymatthews johnnymatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great PR, thanks for submitting! I've suggested a few changes, mainly based around formatting and minor grammar issues. I've not commited them yet, since I think it'd be good for you to take a look and understand the changes I've made.

Copy link
Collaborator Author

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added comments on 2 changes. Everything else looks better than before. Thank you for helping me fix this. I think we are good to merge after you review my 2 comments.

@johnnymatthews johnnymatthews merged commit 37bd34a into filecoin-project:main Dec 6, 2021
@LexLuthr LexLuthr deleted the add/storage-groups branch January 10, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sector storage groups to the lotus-docs
2 participants