Move some of Fevm.Events.* config options to top-level Events #11679
Comments
rvagg
added a commit
that referenced
this issue
Mar 8, 2024
Closes: #11679 * Introduce a `moved:"To.New.Config"` tag which prints a stderr warning when you use one of these, but will move any set value to the new location if the new location isn't already set itself. * Look for `X is DEPRECATED` to hold certain fields back from documentation. * Use `toml:"omitempty"` to prevent the default config output from having these deprecated values.
rvagg
added a commit
that referenced
this issue
Mar 8, 2024
Closes: #11679 * Introduce a `moved:"To.New.Config"` tag which prints a stderr warning when you use one of these, but will move any set value to the new location if the new location isn't already set itself. * Look for `X is DEPRECATED` to hold certain fields back from documentation. * Use `toml:"omitempty"` to prevent the default config output from having these deprecated values.
rvagg
added a commit
that referenced
this issue
Mar 11, 2024
Closes: #11679 * Introduce a `moved:"To.New.Config"` tag which prints a stderr warning when you use one of these, but will move any set value to the new location if the new location isn't already set itself. * Look for `X is DEPRECATED` to hold certain fields back from documentation. * Use `toml:"omitempty"` to prevent the default config output from having these deprecated values.
rvagg
added a commit
that referenced
this issue
Mar 11, 2024
Closes: #11679 * Introduce a `moved:"To.New.Config"` tag which prints a stderr warning when you use one of these, but will move any set value to the new location if the new location isn't already set itself. * Look for `X is DEPRECATED` to hold certain fields back from documentation. * Use `toml:"omitempty"` to prevent the default config output from having these deprecated values.
rvagg
added a commit
that referenced
this issue
Mar 11, 2024
Closes: #11679 * Introduce a `moved:"To.New.Config"` tag which prints a stderr warning when you use one of these, but will move any set value to the new location if the new location isn't already set itself. * Look for `X is DEPRECATED` to hold certain fields back from documentation. * Use `toml:"omitempty"` to prevent the default config output from having these deprecated values.
rjan90
pushed a commit
that referenced
this issue
Mar 22, 2024
Closes: #11679 * Introduce a `moved:"To.New.Config"` tag which prints a stderr warning when you use one of these, but will move any set value to the new location if the new location isn't already set itself. * Look for `X is DEPRECATED` to hold certain fields back from documentation. * Use `toml:"omitempty"` to prevent the default config output from having these deprecated values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#11618 introduces an
Eventstop-level, config option.Fevm.Eventsis full of items that are not FEVM-specific and should be moved:DisableRealTimeFilterAPIDisableHistoricFilterAPIFilterTTL(needs a doc update)MaxFilters(needs doc update)MaxFilterResultsMaxFilterHeightRangeDatabasePathMy proposal is to copy all of these into the new top-level
Eventsand do a reconcile at start-up, prioritising the new top-level version if set. IfFevm.Events.*items are set we'll print a warning to stdout (or via log). Then in a future breaking change, maybe next network version, we removeFevm.Eventsentirely.The blast-radius of changes is people using the Ethereum-compatible log subscription today, which I believe is relatively small. The risk with v1.26.0 if we don't get to this is that we have a new audience of oracle developers using generic actor events APIs who will have broken configs. So sooner than later would be good.
The text was updated successfully, but these errors were encountered: