Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport 10372 onto release/v1.22.0 #10625

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Apr 5, 2023

Backports #10372 , which is needed to update the FVM in nv19.

Related Issues

Proposed Changes

This is now "FVM" native. Changes include:

  1. Don't treat "trace" messages like off-chain messages. E.g., don't include CIDs, versions, etc.
  2. Include IPLD codecs where applicable.
  3. Remove fields that aren't filled by the FVM (timing, some errors, code locations, etc.).

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek arajasek requested a review from a team as a code owner April 5, 2023 15:50
This is now "FVM" native. Changes include:

1. Don't treat "trace" messages like off-chain messages. E.g., don't
include CIDs, versions, etc.
2. Include IPLD codecs where applicable.
3. Remove fields that aren't filled by the FVM (timing, some errors,
code locations, etc.).
@arajasek arajasek merged commit 2dd67dc into release/v1.22.0 Apr 5, 2023
@arajasek arajasek deleted the asr/backport-trace branch April 5, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants