-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont recompute post on revert <<redux>> #3924
Conversation
e4dea8d
to
8e6b255
Compare
22e23c5
to
d33b474
Compare
d33b474
to
7eb9bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good, I don't see anything obviously wrong
The only thing to do here is to convert some things to use the now actor abstraction layer
…ST-abstract Use abstract types for Dont recompute post on revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'd like to run this on some real miner node before merging
(Just worked on 3 partitions on my miner) |
Supersedes #3833
Fixes #3560 #3561
The previous state machine implementation has an issue whereby:
At this point we should resubmit the proof for deadline 5. But the state machine is a single thread, so it would have to either
This PR instead creates two separate go routines:
Each time the head advances
Each time the head changes