Fix off by one tipset in searchBackForMsg #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we will return the tipset the message was executed in Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
approved these changes
Oct 13, 2020
added 2 commits
October 13, 2020 20:02
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
force-pushed
the
fix/msg-search-off-by-one
branch
from
bf25322
to
ce548c8
Compare
magik6k
reviewed
Oct 13, 2020
Comment on lines
+81
to
+88
| var ser []byte | ||
| var err error | ||
| if sm.Signature.Type == crypto.SigTypeBLS { | ||
| // BLS chain message length doesn't include signature | ||
| ser, err = sm.Message.Serialize() | ||
| } else { | ||
| ser, err = sm.Serialize() | ||
| } |
There was a problem hiding this comment.
Looks like a fix for a different issue, mildly fishy consensus-wise, though looking at usages I believe it's fine
There was a problem hiding this comment.
Yeah, it is a fix for the mempool. Doesn't touch consensus as we have no signed BLS message in VM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we will return the tipset the message was executed in