Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a panic on startup when we fail to load the tipset #4376

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

Stebalien
Copy link
Member

There may be a deeper issue here, but we need to handle this more gracefully somehow. See #4358.

There may be a deeper issue here, but we need to handle this more gracefully
somehow. See #4358.
@Stebalien
Copy link
Member Author

An alternative is to turn the following into a hard error:

if err := chain.Load(); err != nil {
log.Warnf("loading chain state from disk: %s", err)
}

But even then, we should still handle the case where no tipset has been loaded.

@magik6k magik6k merged commit 9c6ee80 into master Oct 13, 2020
@magik6k magik6k deleted the steb/fix-load-panic branch October 13, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants