Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup test initialization and always validate VRFs in tests #4538

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Cleanup test initialization and always validate VRFs in tests #4538

merged 2 commits into from
Oct 23, 2020

Conversation

Stebalien
Copy link
Member

  1. Avoid setting global variables multiple times from different tests.
  2. Don't skip VRF validation in tests when "insecure post" is enable. VRFs are always calculated, so we might as well test them.

@Stebalien
Fix global test options
70c39fe 
Set BELLMAN_NO_GPU on init.
Set InsecurePoStValidation once in an obvious place.
@Stebalien
Always validate VRFs, even when insecure post validation is enabled
4a550d1 
We always generate them, we might as well validate them.
@Stebalien
Copy link
Member Author

Extracted from #4513 to simplify review.

@magik6k magik6k merged commit 2c3d804 into master Oct 23, 2020
@magik6k magik6k deleted the steb/test-cleanup-proofs branch October 23, 2020 08:53
@Stebalien Stebalien mentioned this pull request Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k