Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list-asks: remove redundant code. #5148

Closed
wants to merge 1 commit into from
Closed

list-asks: remove redundant code. #5148

wants to merge 1 commit into from

Conversation

raulk
Copy link
Member

@raulk raulk commented Dec 8, 2020

No description provided.

@raulk raulk requested a review from magik6k December 8, 2020 12:28
magik6k
magik6k requested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not redundant, it's how we measure ping (perhaps should have a comment here - the first call is likely to be setting up the connection to the miner which isn't 1 roundtrip)

@magik6k
Copy link
Contributor

magik6k commented Dec 8, 2020

See #5060 (comment)

@magik6k
Copy link
Contributor

magik6k commented Dec 9, 2020

Going to close this - a nicer / more correct fix would be to record this in markets.

@magik6k magik6k closed this Dec 9, 2020
@Kubuxu Kubuxu deleted the fix/client-ask branch November 25, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k requested changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulk @magik6k