fix build-lotus-soup ci job
#5554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Feb 8, 2021
| @@ -165,7 +165,7 @@ func PrepareMiner(t *TestEnvironment) (*LotusMiner, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| ds, err := lr.Datastore(context.Background(), "/metadata") | |||
There was a problem hiding this comment.
It looks like this isn't using lotus from master - https://github.com/filecoin-project/lotus/blob/master/node/repo/interface.go#L58
There was a problem hiding this comment.
That's right, sorry about this.
The problem was that build-lotus-soup was missing a step to go get github.com/filecoin-project/lotus@master and this was indeed building an outdated commit from master.
I've added the step, so now on every CI run, we build against Lotus from master, which is what we want.
magik6k
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
build-lotus-soupjob is failing on CI, due to missing step to fetch latest lotus dependency from master.