fix: return buffers after canceling badger operation #5796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory, Delete/Put could fail. If it does, we'll return the buffers to the pool before we're really done with them. In practice, this is almost certainly not an issue as badger shouldn't _use_ the buffer unless we flush. But I feel slightly safer this way.
Stebalien
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, Delete/Put could fail. If it does, we'll return the buffers to the pool before we're really done with them.
In practice, this is almost certainly not an issue as badger shouldn't use the buffer unless we flush. But I feel slightly safer this way.