implement a command to export a car #6405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
steb/export-car
branch
from
8d3012d
to
f248674
Compare
magik6k
approved these changes
Jun 7, 2021
|
|
||
| var exportCarCmd = &cli.Command{ | ||
| Name: "export-car", | ||
| Description: "Export a car from repo (requires node to be offline)", |
There was a problem hiding this comment.
We could support online-mode with the API blockstore (blockstore.NewAPIBlockstore)
There was a problem hiding this comment.
Is there a good way to detect this?
There was a problem hiding this comment.
I guess do something like what we do in https://github.com/filecoin-project/lotus/blob/master/cli/wait.go
Could also just be an explicit --offline flag
There was a problem hiding this comment.
Eh, I'd rather not spend time on this for now.
magik6k
reviewed
Jun 8, 2021
|
(comments not blocking merge, this is already pretty useful) |
Stebalien
force-pushed
the
steb/export-car
branch
from
f248674
to
4624b20
Compare
|
@magik6k I'm not able to merge this. |
magik6k
reviewed
Jun 9, 2021
cmd/lotus-shed/export-car.go
Outdated
| package main | ||
|
|
||
| import ( | ||
| "context" |
There was a problem hiding this comment.
"just one little change, what could go wrong"
Stebalien
force-pushed
the
steb/export-car
branch
from
4624b20
to
a64a059
Compare
magik6k
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a lotus-shed command for exporting a car of an arbitrary dag.
Currently, we allow exporting tipsets, etc. But we don't have any convenient commands for simply exporting an arbitrary dag for analysis. This is useful for, e.g., analyzing bad actor states.