Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft: basic build instructions on Readme #6498

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Initial draft: basic build instructions on Readme #6498

merged 3 commits into from
Jun 21, 2021

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Jun 16, 2021

Inital draft for basic build instructions on the Readme page. Issue: #6348

Inital draft for basic build instructions on the Readme page. Issue: #6348
@jennijuju jennijuju linked an issue Jun 16, 2021 that may be closed by this pull request
@jennijuju
Copy link
Member

Thank you @rjan90 for working on this!!

README.md Outdated

#### Go

To build Lotus, you need a working installation of [Go 1.16.1 or higher](https://golang.org/dl/):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To build Lotus, you need a working installation of [Go 1.16.1 or higher](https://golang.org/dl/):
To build Lotus, you need a working installation of [Go 1.16.4 or higher](https://golang.org/dl/):

git clone https://github.com/filecoin-project/lotus.git
cd lotus/
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Note: The default branch `master` is the dev branch where the latest new features, bug fixes and improvement are in. However, if you want to run lotus on Filecoin mainnet and want to run a production-ready lotus, get the latest release[ here](https://github.com/filecoin-project/lotus/releases).

README.md Outdated
5. Build and install Lotus:

```sh
make clean all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make clean all
make clean all #mainnet

@jennijuju jennijuju requested a review from arajasek June 16, 2021 21:03
README.md Outdated

```sh
export RUSTFLAGS="-C target-cpu=native -g"
export FFI_BUILD_FROM_SOURCE=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say that the basic instructions should probably use the prebuilt proof binaries - this way you don't have to install rustup, and build the proofs library which takes a while. Then we can link to the instructions on docs.filecoin.io for people who may want a full from-source build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think the proof prebuilds are compatible with different systems atm? And isn’t building from source a pretty standard thing to do now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh checked with nemo, i was wrong, magik is right. @rjan90 mind making the update?

Make the basic build instructions use the prebuilt proof binaries instead of building them from source. Removed rustup as a dependency, and linked to it in the full docs instead.
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for the PR!

@magik6k magik6k merged commit ae65e65 into filecoin-project:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Readme doesnt contain basic build instructions
3 participants