Get retrieval pricing input should not error out on a deal state fetch #6679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
reviewed
Jul 5, 2021
| @@ -138,7 +138,8 @@ func (rpn *retrievalProviderNode) GetRetrievalPricingInput(ctx context.Context, | |||
| for _, dealID := range storageDeals { | |||
| ds, err := rpn.full.StateMarketStorageDeal(ctx, dealID, tsk) | |||
| if err != nil { | |||
| return resp, xerrors.Errorf("failed to look up deal %d on chain: err=%w", dealID, err) | |||
| log.Warnf("failed to look up deal %d on chain: err=%w", dealID, err) | |||
There was a problem hiding this comment.
I suggest that if attempting to fetch the state for all deals fails, we return the error (instead of just logging it) so it's clearer what the root cause is
There was a problem hiding this comment.
Fixed this. Thanks.
raulk
reviewed
Jul 5, 2021
|
@aarshkshah1992 lint fails. |
|
@raulk Have addressed your review and lint is now green. |
|
Note that the CI test failure is a known flaky. |
dirkmc
approved these changes
Jul 5, 2021
magik6k
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6678.
We iterate over all storage deals for a payload to see if we have a verified storage deal with the required PieceCID to fetch the input for the retrieval pricing function. This PR introduces a fix so we don't error out in we fail to look up a deal state and just continue iterating over the other deals.