support MARKETS_API_INFO env var, and markets-repo, markets-api-url CLI flags. #6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
added
epic/MRA
team/ignite
raulk
force-pushed
the
feat/markets-env-var
branch
from
3b2691a
to
f27a71c
Compare
raulk
force-pushed
the
feat/markets-env-var
branch
from
f27a71c
to
3b2c3a3
Compare
raulk
force-pushed
the
feat/markets-env-var
branch
from
349340b
to
9c698a1
Compare
raulk
force-pushed
the
feat/markets-env-var
branch
from
9c698a1
to
90427bc
Compare
nonsense
reviewed
Jul 29, 2021
Kubuxu
approved these changes
Jul 29, 2021
This was referenced Jul 29, 2021
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6935.
Adds support for the
MARKETS_API_INFOenv variable,markets-api-urlflag, andmarkets-repoflag.The markets API endpoint/client is now exposed through
GetMarketsAPI(), which works with both monolith and split deployments by handling multiple environment variables in order of precedence.Command actions have been refactored to use the appropriate API (
GetStorageMinerAPI,GetMarketsAPI).In the near future, we want to create a
lotus-marketsbinary entrypoint. Until then, markets and storage miner client commands have a single entrypointlotus-miner, which creates ambiguity when calling common commands (e.g. log, auth, pprof,net).To solve for that, I've added a flag to select the markets node:
This is marked as temporary, because we ultimately don't want it here, but we also don't have the bandwidth to create the
lotus-marketsentrypoint just now.This PR does not affect the miner server-side, only the
lotus-minerclient CLI UX.