Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caches to lotus-stats and splitcode #7329

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

travisperson
Copy link
Contributor

No description provided.

@travisperson travisperson force-pushed the feat/lotus-stats-update branch 3 times, most recently from 25b9207 to 3b7a907 Compare October 26, 2021 21:30
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #7329 (edf3432) into master (e0a9cae) will decrease coverage by 0.11%.
The diff coverage is 3.70%.

❗ Current head edf3432 differs from pull request most recent head 2d4f595. Consider uploading reports for the commit 2d4f595 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7329      +/-   ##
==========================================
- Coverage   39.88%   39.77%   -0.12%     
==========================================
  Files         633      634       +1     
  Lines       67098    67184      +86     
==========================================
- Hits        26765    26720      -45     
- Misses      35740    35857     +117     
- Partials     4593     4607      +14     
Impacted Files Coverage Δ
cmd/lotus-pcr/main.go 0.00% <0.00%> (ø)
tools/stats/influx/influx.go 0.00% <0.00%> (ø)
tools/stats/ipldstore/ipldstore.go 0.00% <0.00%> (ø)
tools/stats/points/collect.go 0.00% <0.00%> (ø)
tools/stats/sync/sync.go 0.00% <0.00%> (ø)
cmd/lotus-stats/main.go 0.86% <1.47%> (+0.86%) ⬆️
tools/stats/headbuffer/head_buffer.go 90.00% <90.00%> (ø)
chain/events/message_cache.go 87.50% <0.00%> (-12.50%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a9cae...2d4f595. Read the comment docs.

@travisperson travisperson marked this pull request as ready for review October 26, 2021 22:34
@travisperson travisperson requested a review from a team as a code owner October 26, 2021 22:34
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine as is

@magik6k magik6k merged commit 81a2f2f into master Nov 22, 2021
@magik6k magik6k deleted the feat/lotus-stats-update branch November 22, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants