Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lotus-shed msg: Decode submessages/msig proposals #7639

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 17, 2021

Very useful when viewing msig propose messages which call methods on other things

@magik6k magik6k requested a review from a team as a code owner November 17, 2021 22:12
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #7639 (9adaa9b) into master (e196a81) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7639      +/-   ##
==========================================
- Coverage   39.81%   39.70%   -0.11%     
==========================================
  Files         633      633              
  Lines       67258    67263       +5     
==========================================
- Hits        26776    26707      -69     
- Misses      35891    35952      +61     
- Partials     4591     4604      +13     
Impacted Files Coverage Δ
cmd/lotus-shed/msg.go 0.00% <0.00%> (ø)
chain/gen/slashfilter/slashfilter.go 40.00% <0.00%> (-12.00%) ⬇️
storage/wdpost_sched.go 75.49% <0.00%> (-11.77%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/stmgr/call.go 67.87% <0.00%> (-7.28%) ⬇️
miner/miner.go 54.30% <0.00%> (-5.30%) ⬇️
chain/exchange/peer_tracker.go 66.66% <0.00%> (-4.31%) ⬇️
node/hello/hello.go 63.63% <0.00%> (-3.41%) ⬇️
blockstore/buffered.go 40.00% <0.00%> (-2.23%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-1.89%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e196a81...9adaa9b. Read the comment docs.

@jennijuju
Copy link
Member

@dkkapur you will love this

@magik6k magik6k merged commit 943c40a into master Nov 18, 2021
@magik6k magik6k deleted the feat/shed-msg-submsg branch November 18, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants