Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup partial retrieval codepaths ( zero functional changes ) #7688

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

ribasushi
Copy link
Collaborator

- Adjust the ExportRef comment to reflect change from #7673
- Simplify control flow in parseDagSpec() ( read diff under -w )
@ribasushi ribasushi requested a review from a team as a code owner November 25, 2021 09:35
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #7688 (d5b4d93) into master (ab55a6f) will decrease coverage by 0.08%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7688      +/-   ##
==========================================
- Coverage   39.56%   39.48%   -0.09%     
==========================================
  Files         637      637              
  Lines       67924    67924              
==========================================
- Hits        26877    26817      -60     
- Misses      36445    36489      +44     
- Partials     4602     4618      +16     
Impacted Files Coverage Δ
api/types.go 52.77% <ø> (ø)
node/impl/client/client.go 49.69% <66.66%> (-0.25%) ⬇️
node/modules/dtypes/mpool.go 87.50% <0.00%> (-12.50%) ⬇️
blockstore/api.go 24.00% <0.00%> (-8.00%) ⬇️
blockstore/blockstore.go 62.96% <0.00%> (-7.41%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
chain/stmgr/execute.go 86.95% <0.00%> (-4.35%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
chain/sub/incoming.go 54.43% <0.00%> (-3.38%) ⬇️
node/impl/full/mpool.go 25.21% <0.00%> (-1.74%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab55a6f...d5b4d93. Read the comment docs.

@magik6k magik6k merged commit 77d75b7 into master Nov 29, 2021
@magik6k magik6k deleted the chore/partret_cleanup_comment_and_flow branch November 29, 2021 15:39
@ribasushi
Copy link
Collaborator Author

@magik6k just a reminder: we should still fix the export-to-car effectively not working as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants