disable mplex stream muxer #7689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7689 +/- ##
==========================================
- Coverage 39.56% 39.48% -0.09%
==========================================
Files 637 637
Lines 67924 67909 -15
==========================================
- Hits 26877 26811 -66
- Misses 36445 36482 +37
- Partials 4602 4616 +14
Continue to review full report at Codecov.
|
jennijuju
requested review from
whyrusleeping
and removed request for
a team
marten-seemann
force-pushed
the
disable-mplex
branch
from
2318f16
to
9739f65
Compare
vyzo
approved these changes
Nov 25, 2021
|
needs |
marten-seemann
force-pushed
the
disable-mplex
branch
from
9739f65
to
cf0faf5
Compare
magik6k
reviewed
Nov 26, 2021
Stebalien
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility considerations: The reason we have mplex in IPFS is that js-libp2p doesn't support yamux, so mplex is the fallback stream muxer there. We don't care about js-libp2p in lotus. As far as I know (someone with more ecosystem insight please double check!), all Filecoin implementations support yamux (at least Venus does), so there's no need for a fallback.