Shed: Add a util to list terminated deals #7774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7774 +/- ##
==========================================
- Coverage 39.57% 39.47% -0.10%
==========================================
Files 640 641 +1
Lines 68469 68553 +84
==========================================
- Hits 27097 27062 -35
- Misses 36728 36829 +101
- Partials 4644 4662 +18
Continue to review full report at Codecov.
|
jennijuju
force-pushed
the
asr/shed-pieces
branch
from
164dbc9
to
fc2e835
Compare
jennijuju
force-pushed
the
asr/shed-pieces
branch
2 times, most recently
from
3020f91
to
f5a7feb
Compare
|
Do we want this merged? I'd be happy to close without merge, unless we think it'll be useful. |
magik6k
reviewed
Dec 16, 2021
|
|
||
| var terminationsCmd = &cli.Command{ | ||
| Name: "terminations", | ||
| Description: "Lists terminated deals from the past 2 days", |
There was a problem hiding this comment.
Would be much more landable if this had a flag to specify the period
arajasek
force-pushed
the
asr/shed-pieces
branch
from
f5a7feb
to
fac769f
Compare
|
@magik6k done |
magik6k
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And another to calc burnt funds given a list of msgs